Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style] Add GitHub action for linter and pre-commit hook for formating #411

Closed
wants to merge 1 commit into from
Closed

[Style] Add GitHub action for linter and pre-commit hook for formating #411

wants to merge 1 commit into from

Conversation

Neet-Nestor
Copy link
Contributor

Currently this repo doesn't have a formatter setup. Besides, even though we have ESLint rule set up, these rules are not currently enforced in this repo.

This PR adds the following to ensure better code quality:

  • Add prettier for code auto formatting
  • Run prettier format on every commit using pre-commit hook
  • Add GitHub actions for automatically checks ESLint and Prettier on PRs and pushes

@Neet-Nestor
Copy link
Contributor Author

Duplicated #412 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieFRuan CharlieFRuan Awaiting requested review from CharlieFRuan

@tqchen tqchen Awaiting requested review from tqchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Neet-Nestor